Closed hmgaudecker closed 4 years ago
Probability anchoring was just dropped. I agree with the other renaming proposals.
Yes, save_intermediate_optimization_results
, save_path
, start_params
, maxiter
and maxfun
should actually not be part of skillmodels and definitely not of the model specification but just be passed through to estimagic.maximize
via the fit method.
@janosg: Please disapprove where you see fit...
Sort-of related:
save_intermediate_optimization_results
andsave_path
seem more useful as optional parameters to thefit()
method rather than model-level constants. Same comment forstart_params
,start_values_per_quantity
,maxiter
,maxfun
.