search

OpenSourceEconomics / skillmodels

MIT License
11 stars 5 forks source link

Support more edge cases #60

Closed janosg closed 2 years ago

janosg commented 3 years ago

Estimating one factor models makes it necessary to support a few more edge cases:

  1. Periods without measurements of any factor
  2. Dataset has more periods than model

I also fix the conda build in this PR.

codecov-commenter commented 3 years ago

Codecov Report

Merging #60 (dea8d0a) into master (5a577f9) will increase coverage by 0.15%. The diff coverage is 98.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   92.67%   92.83%   +0.15%     
==========================================
  Files          29       28       -1     
  Lines        2130     2163      +33     
==========================================
+ Hits         1974     2008      +34     
+ Misses        156      155       -1
Impacted Files Coverage Δ
skillmodels/config.py 100.00% <ø> (ø)
skillmodels/process_data.py 94.59% <87.50%> (+0.84%) :arrow_up:
skillmodels/likelihood_function.py 87.70% <100.00%> (+0.10%) :arrow_up:
skillmodels/process_model.py 98.73% <100.00%> (+0.08%) :arrow_up:
skillmodels/tests/test_likelihood_regression.py 98.33% <100.00%> (+1.45%) :arrow_up:
skillmodels/tests/test_process_data.py 100.00% <100.00%> (ø)
skillmodels/tests/test_process_model.py 100.00% <100.00%> (ø)
skillmodels/tests/test_simulate_data.py 100.00% <100.00%> (ø)
skillmodels/tests/test_utilities.py 100.00% <100.00%> (ø)
skillmodels/utilities.py 89.51% <100.00%> (-0.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a577f9...dea8d0a. Read the comment docs.