OpenSourceEconomics / skillmodels

MIT License
12 stars 6 forks source link

Move all plotting functions to plotly. #69

Closed mpetrosian closed 1 year ago

mpetrosian commented 2 years ago

Visualize transition functions and factor distributions using python's plotly library.

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@8ceeeae). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage        ?   91.11%           
=======================================
  Files           ?       39           
  Lines           ?     3084           
  Branches        ?        0           
=======================================
  Hits            ?     2810           
  Misses          ?      274           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

hmgaudecker commented 2 years ago

And while you are at it, I think the input_factors and output_factors arguments should go from combine_subplots.

Instead, tell the user to remove any subplots from model_dict that she does not want to see included. Then pass in the model_dict as well, looping over factors in the correct order. If some factor is not found in x / y, do not show that row.

There should be a possibility of including blank rows / columns, e.g. by leaving the key ("a", "b") in model_dict but setting the value to None instead of a plot.

(the current approach does not allow for gaps, remember that my application features irregular factors across periods, some factors are not around in some periods).