OpenSourceEconomics / temfpy

Test models and functions for standard numerical components in computational economic models
https://temfpy.readthedocs.io
MIT License
2 stars 1 forks source link

Manuhuth patch 1 #30

Closed manuhuth closed 3 years ago

manuhuth commented 3 years ago

I haven't tried the underscore so far, since this allready indicated an error in spyyder that the functions are missing. We can still try i tho :)

The function of interest is multinomial_probit in the file 'econometrics.py'. The functions in 'integration_methods' are needed for the mn probit functions. I haven't done any example by now. Linda hasone in her repository (https://github.com/peisenha/discrete_choice/blob/master/discrete_choice/numerical_example_multinomial.ipynb) but I wasn't sure if we are allowed to use the data she uses. Moreover, the item 'Notes' needs some text. However, I wanted to receive a first opinion. Reach out at any time if something is unclear! :)

Thanks for reviewing!

codecov[bot] commented 3 years ago

Codecov Report

Merging #30 into master will decrease coverage by 53.19%. The diff coverage is 10.68%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #30       +/-   ##
===========================================
- Coverage   97.59%   44.39%   -53.20%     
===========================================
  Files           5        7        +2     
  Lines          83      214      +131     
===========================================
+ Hits           81       95       +14     
- Misses          2      119      +117     
Impacted Files Coverage Δ
temfpy/integration_methods.py 7.93% <7.93%> (ø)
temfpy/econometrics.py 13.23% <13.23%> (ø)