search

OpenSourceEconomics / temfpy

Test models and functions for standard numerical components in computational economic models
https://temfpy.readthedocs.io
MIT License
2 stars 1 forks source link

Fixed issues with running locally. #51

Closed s6emschw closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #51 (7352af9) into master (dfc0f15) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files          11       11           
  Lines         550      550           
=======================================
  Hits          522      522           
  Misses         28       28
Impacted Files Coverage Δ
temfpy/integration.py 94.73% <ø> (ø)
temfpy/optimization.py 89.28% <ø> (ø)
s6emschw commented 3 years ago

Please just align the naming convention of files that we only have "-" instead of a mix between "-" and "_". Then go ahead and merge, please also be sure to update on our conda channel.

Will do! I'm just not so sure what you mean by updating the conda channel. I only changed the labeling of an x-axis and everything else was left as is. Do I still need to do something with the conda channel?

peisenha commented 3 years ago

No, that is fine of course.

Philipp Eisenhauer Economist

Mail @.**@.) Web https://peisenha.github.io Repository https://github.com/peisenha

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Tuesday, October 12th, 2021 at 12:37 PM, s6emschw @.***> wrote:

Please just align the naming convention of files that we only have "-" instead of a mix between "-" and "_". Then go ahead and merge, please also be sure to update on our conda channel.

Will do! I'm just not so sure what you mean by updating the conda channel. I only changed the labeling of an x-axis and everything else was left as is. Do I still need to do something with the conda channel?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

s6emschw commented 3 years ago

In commit, I changed _ in all file names to -.

luward commented 3 years ago

The CI and pre-commit seem to be failing at the same point, you'll have to review import statements for temfpy.nonlinear-equations in multiple test python files.