search

OpenSourceEconomics / temfpy

Test models and functions for standard numerical components in computational economic models
https://temfpy.readthedocs.io
MIT License
2 stars 1 forks source link

Add Linear Equation Rubric #52

Closed s6emschw closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #52 (dc886fe) into master (6a8e371) will decrease coverage by 0.18%. The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   94.90%   94.72%   -0.19%     
==========================================
  Files          11       13       +2     
  Lines         550      569      +19     
==========================================
+ Hits          522      539      +17     
- Misses         28       30       +2
Impacted Files Coverage Δ
temfpy/linear_equations.py 88.88% <88.88%> (ø)
temfpy/tests/test_linear_equations.py 90.00% <90.00%> (ø)
s6emschw commented 2 years ago

A few specifics to clarify:

  1. How should I improve the introductory sentence? ("We provide a variety of linear equations..." doesn't really cut it.)
  2. Is the equation trivial enough to remove?
  3. Is there a particular reference I should include for this equation?
  4. Should I include any elaborative notes on the equation?
  5. Is the example sufficient? Or should I elaborate?

I still haven't produced a tests script, but I figured I can do that after the rubric draft is completed.

Any further comments would be greatly appreciated.