Open DietBepis1 opened 1 year ago
Hello Jimmy, I would like to work on this issue. It's my first one also.
Hello Jimmy, I would like to work on this issue. It's my first one also.
Happy to work on this together with you George.
Hello Jimmy, I would like to work on this issue. It's my first one also.
Happy to work on this together with you George.
@george-kokonas @JimmyAyivor Feel free to pair programme. Check this out to learn how to co-author commits in Git if you want: Creating a commit with multiple authors
Cool feature @paramsiddharth. Thanks for sharing, will definitely make use of it.
Hello Jimmy, I would like to work on this issue. It's my first one also. Having trouble finding you on the slack channel @george-kokonas, are you on there by any chance?
I'm not on slack, but give me a some time and I will join. @JimmyAyivor
I've joined slack, how can I find you? @JimmyAyivor
I think since we are not in same channel @george-kokonas, I can only start a chat with you using your email
I'm not on slack, but give me a some time and I will join.
Ok, I'm sending you my email to your email @JimmyAyivor
@.***
Get Outlook for Androidhttps://aka.ms/AAb9ysg
From: Jimmy Ayivor @.> Sent: Monday, February 13, 2023 7:05:30 PM To: ProgramEquity/amplify @.> Cc: George Kokonas @.>; Mention @.> Subject: Re: [ProgramEquity/amplify] Add Validations to Letter Workflow (Issue #491)
I think since we are not in same channel, I can only start a chat with you using your email
— Reply to this email directly, view it on GitHubhttps://github.com/ProgramEquity/amplify/issues/491#issuecomment-1428312797, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A25ELSJFNKEOUW27CUOLWETWXJSVVANCNFSM6AAAAAAUZLQLEM. You are receiving this because you were mentioned.Message ID: @.***>
or just use mine @george-kokonas, its my first and last name at gmail
@JimmyAyivor i added you on slack, did you receive any invitation?
@george-kokonas sorry please use same name at pursuit dot org
@JimmyAyivor ok , sent you an invitation. did you received it?
We need to refactor more validations in frontend
Directions
In file /amplify/src/components/SignName.vue. Highlight lines 164-181
User Story
Currently, a user may simply ignore filling out their information and complete the checkout process for sending a letter. This may incorrectly imply to the user that they are anonymously sending a campaign letter, but without their information, we are unable to correct record a transaction or display the checkout completion page. If you try it, you'll see the page has an infinite loading animation and many errors logged to the brower's console.
We need to ensure that when a user clicks 'Next' in step 2, they have actually filled the form out.