OpenSourceHelpCommunity / OpenSourceHelpCommunity.github.io

Open source help community website
http://opensourcehelpcommunity.herokuapp.com/
MIT License
44 stars 57 forks source link

Attempt to make it responsive #217

Closed anubhakushwaha closed 6 years ago

anubhakushwaha commented 6 years ago

Checklist

Which issue does this PR fix?: fix partially #207

Brief description of what this PR does. Attempts to make the web page responsive, this can be achieved by setting the element sizes in percentages rather than pixels as mentioned in this post

If relevant, please include a screenshot. Different screen sizes 1000

1001

1002

1003

A picture of a cute animal (not mandatory but encouraged): q

anubhakushwaha commented 6 years ago

@tapasweni-pathak @jarifibrahim I have attempted at making it responsive, please let me know if you know another way of doing it better. Please review.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 72.269% when pulling d709b62f12164c1d4982a9c85947c1bf163d6233 on anubhakushwaha:makeResponsive into ea6096f7e2c062fcddaef66f34fc43769fdc2cbd on OpenSourceHelpCommunity:predev.

vaibhavsingh97 commented 6 years ago

@anubhakushwaha Can you deploy somewhere and give us the live demo link

jarifibrahim commented 6 years ago

@vaibhavsingh97 You could just run do a python manage.py collectstatic followed by python manage.py runserver. We don't have to deploy it just for reviewing.

tapaswenipathak commented 6 years ago

^ 🐼 😄

anubhakushwaha commented 6 years ago

@tapasweni-pathak Sure, will update you on this.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 72.269% when pulling 16458cabb14897399afb1d2c97a7f9fb013ab68a on anubhakushwaha:makeResponsive into 3741eedcbd8025cf979fb7c2569e8d69380307d8 on OpenSourceHelpCommunity:predev.

anubhakushwaha commented 6 years ago

@tapasweni-pathak I tested by zooming in the screen and it works well there as well as the right: and left: are relative to the rectangles. Let me know if I understood something wrong :fallen_leaf: screenshot from 2018-01-06 13-19-36

tapaswenipathak commented 6 years ago

👋 @anubhakushwaha, can you try with zooming out?

Edit: One extra 👀 I see this issue on my localhost but not with our live urls. 😕

tapaswenipathak commented 6 years ago

For some reason I only see it on different browsers in localhost and not on heroku on different browsers. Can someone please check it on how does it look on IE? Merging this, thanks for the work @anubhakushwaha 🎉.

tapaswenipathak commented 6 years ago

By the way you event made your commit message as an attempt [..], :D