OpenSourceHelpCommunity / OpenSourceHelpCommunity.github.io

Open source help community website
http://opensourcehelpcommunity.herokuapp.com/
MIT License
44 stars 57 forks source link

Removed "_blank" #220

Closed aaronmaynard closed 6 years ago

aaronmaynard commented 6 years ago

to maintain attribute availability for future use.

Checklist

Which issue does this PR fix?: fixes #210 Removes the common attribute "_blank", which opens links in a new tab instance. Replaced with browser default "_self", the default. This has been applied to:

Why do we need this PR?:

Helps user experience by preventing the need to switch over to the new window/tab

Testing instructions:

N/A

TODOs (if any):

A picture of a cute animal (not mandatory but encouraged):

2-face

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 72.269% when pulling 5c9037a9f6b6bd1b5ccb6e71b30f42fb9f81a7d9 on aaronmaynard:patch-1 into 514be0501b5dd94908a7b35ddf2cabc4e24d7d51 on OpenSourceHelpCommunity:predev.

tapaswenipathak commented 6 years ago

You can only fix one first-timers-only pull request, so I have to close this one, thanks for picking this! curious for ☝️ question.