OpenSourceHelpCommunity / OpenSourceHelpCommunity.github.io

Open source help community website
http://opensourcehelpcommunity.herokuapp.com/
MIT License
44 stars 57 forks source link

Fix for #210: Removed target attribute from some links. #227

Closed Nickatak closed 6 years ago

Nickatak commented 6 years ago

Checklist

Which issue does this PR fix?: Fixes issue #210 (links undesirably opening in new tab).

This PR removes the target attribute entirely for each anchor tag mentioned in issue 210 inside /oshc/main/templates/base.html. To allow for consistency, I opted to completely remove the target attribute so that it matches other in-tab-opening links on the same page. This removal has been applied to the following links:

Why do we need this PR?: UI/UX alteration to provide for favorable user interaction (altered links don't open in new tab when they don't need to).

Testing instructions: I have taken the following steps, and am leaving them unchecked below for you to use:

TODOs (if any): None

A picture of a cute animal (not mandatory but encouraged): Old but good: pzhjedp

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 72.269% when pulling 4cf45634709c3efb064a414111789d7bf60f972e on Nickatak:predev into 850a09f2d46f693e723d35fa96faa323c9b9d21e on OpenSourceHelpCommunity:predev.