search

OpenSourceLAN / gameservers-docker

A bunch of game servers I use, dockerised
Other
510 stars 68 forks source link

fixed lines for wreckfest and added docker-compose that I am using #31

Open raynfalldown opened 1 year ago

raynfalldown commented 1 year ago

This is my first PR so any feedback is appreciated.

I spent some time to get your Wreckfest dockerfiles working because they were giving some errors as-is.

The wine/Dockerfile was modified with a command to remove the .fontconfig folder due to some corruption error messages when launching the server.

I fixed a typo for xvfb on wine/README.md.

I rearranged the wreckfest/Dockerfile a little. I had to add the RUN winecfg command as the second part of the .fontconfig folder corruption that I mentioned above. I removed the USER root command because it didn't seem necessary.

I added wreckfest/docker-compose.yml because I run my containers with docker-compose and figure others might as well. It is working correctly as of this writing. The version:3.0 is arbitrary.

wreckfest/start-wreckfest.sh adds sleep 1s because there were some issues with the server not starting correctly otherwise. I also added xvfb-run to the exec command to make the server actually run correctly.

I hope this helps others who are running into issues with these dockerfiles. Again, I am open to feedback on this. I am not sure if the wine?Dockerfile is the correct place to remove the .fontconfig folder, but it has worked so far.

Thanks in advance.

raynfalldown commented 1 year ago

As an update to this, I was using ubuntu:18.04 locally since 16.04 is out of LTS at this point. I did not update the base image at the time of this original pull request. I have fixed that to make everything in my local env match the repo here. I also changed the sleep from 1s to 5s to help make sure the server starts correctly each time.

raynfalldown commented 1 year ago

I noticed that you updated the base to 20.04 on the pax2022 branch, so I did the same on my local copy and rebuilt the images. The server is still working correctly on 20.04 with the changes that I have made in this PR.