Closed GoogleCodeExporter closed 9 years ago
Greg Lu's patch from the trunk.
Original comment by ryan.justin.smith@gmail.com
on 22 Jan 2012 at 2:57
Attachments:
Changes committed to trunk.
Original comment by ryan.justin.smith@gmail.com
on 22 Jan 2012 at 2:58
Sorry I handled connection pooling differently and missed to include it. Any
way glad to have a fix from Greg Lu.
Original comment by karthik...@gmail.com
on 23 Jan 2012 at 4:23
It cant be all your fault Karthik! I reviewed the patch and committed it after
testing it out myself. I looked at the code and just assumed it was some much
simpler way of doing pooling. Heh, whoops! And yes, Im very glad that Greg
Lu has a large enough deployment he can basically do testing on hbase-writer
for us.
I just made a ticket to add testing to the unit test phase to check for
resource pooling. But from now on, Ill run my test crawl using JMX, and log in
using jconsole to check object creation before I commit any more patches. This
way I can just run a short crawl to check for object creation.
Original comment by ryan.justin.smith@gmail.com
on 23 Jan 2012 at 1:10
Original issue reported on code.google.com by
ryan.justin.smith@gmail.com
on 22 Jan 2012 at 2:55