search

OpenSourcePolitics / osp-app

App de référence pour les implémentations de Decidim (https://github.com/OpenSourcePolitics/decidim) par OSP.
8 stars 8 forks source link

Feature add orejime cookies #123

Closed Quentinchampenois closed 4 years ago

Quentinchampenois commented 4 years ago

Add Decidim cookies module using Orejime on release/0.22-stable version.

Subtasks

Quentinchampenois commented 4 years ago

Hi @paulinebessoles, this PR is ready for a product review if you want

paulinebessoles commented 4 years ago

Hi @Quentinchampenois ! Thanks, I reviewed it and have a few feedbacks :)

  1. The piwik cookies are not displayed (may be it's because I tested in local)

    Capture d’écran 2020-10-26 à 16 44 30

  2. The "Revoke cookies" link isn't behaving like expected: when clicking on the link, nothing happens, although it's working properly in private navigation. I think Armand fixed it for CultuurConnect last sprint, but I can't find his fix (for the original issue, see here : https://www.notion.so/opensourcepolitics/CultuurConnect-bug-revoke-cookies-ac69835c34ee4421acc0b2817074e49d)

paulinebessoles commented 4 years ago

I tested again with @Quentinchampenois, great work! 👏 It works perfectly