OpenSourceRisk / ORE-SWIG

Other
49 stars 46 forks source link

Remove constructor bodies in ibor and overnight indexes #22

Closed eltoder closed 1 year ago

eltoder commented 1 year ago

This looks like a confusion with %extend syntax for constructors[1]. These are regular constructors, so the syntax is wrong, but the bodies are ignored by SWIG anyway.

[1] https://www.swig.org/Doc4.1/Python.html#Python_nn43

eltoder commented 1 year ago

@pcaspers Could you take a look please?

eltoder commented 1 year ago

@rolandlichters maybe you can take a look? thanks!

eltoder commented 1 year ago

@pcaspers friendly ping

pcaspers commented 1 year ago

@eltoder same as for the other PR, will merge this soon.

eltoder commented 1 year ago

@pcaspers Any updates on this please?

pcaspers commented 1 year ago

@eltoder apologies, this fell between the cracks. I just ran the change through our tests and merge it here now too. Thanks for spotting this and providing the fix.

eltoder commented 1 year ago

Thank you!