OpenSpace / OpenSpace

This is the official GitHub repository for OpenSpace: an open source astrovisualization project. For instructions on how to build and run OpenSpace, see the Getting Started Guides on the wiki page at http://docs.openspaceproject.com.
http://openspaceproject.com
Other
761 stars 118 forks source link

Volume rendering blending artifacts #1208

Open alexanderbock opened 4 years ago

alexanderbock commented 4 years ago

Report from Alex @ NCMNS • Black square frame surrounding MW galaxy blocks out the background.

I assume this means that the transparent layers of the volume rendering are blocking the incoming Tully billboards

jccosta commented 4 years ago

I cannot reproduce this issue (see pic attached). @alexanderbock, I propose we close this issue. Screenshot from 2020-07-01 09-39-45

WeirdRubberDuck commented 4 years ago

Do you think this can be what he means?

video link

jccosta commented 4 years ago

@WeirdRubberDuck, I don't have permission to watch (access) the video.

WeirdRubberDuck commented 4 years ago

@jccosta sorry! Changed the link, please try again :)

WeirdRubberDuck commented 4 years ago

The artifact is seen easier if the milky way image in scaled up. Also, the result differs when varying transparency:

video

jccosta commented 4 years ago

Weirdest thing, it only happens if the fade-in effect is enabled for Tully galaxies. I tested w/ it disabled.

Disabled: Fade-In-Disabled

Enabled: Fade-In-Enabled

jccosta commented 4 years ago

The artifact is seen easier if the milky way image in scaled up. Also, the result differs when varying transparency:

video

Thanks!

WeirdRubberDuck commented 4 years ago

The artifact is seen easier if the milky way image in scaled up. Also, the result differs when varying transparency: video

Thanks!

Np! Just happy the time I spent wondering about this and fiddling with values happened to be relevant :D

hedbergj commented 3 years ago

Seems to still be there, at least with the stellar streams data added.

OpenSpace_000000

micahnyc commented 3 years ago

Reopening for macos

alexanderbock commented 8 months ago

Need to investigate if it is still an issue and whether it is actually still an issue on Windows.

alexanderbock commented 8 months ago

Also: What is the proposed solution for dealing with the depth-testing issue?