OpenSpeedShop / openspeedshop

Open|SpeedShop is a community effort by The Krell Institute with current direct funding from DOE’s NNSA and Office of Science. It is building on top of a broad list of community infrastructures, most notably Dyninst and MRNet from UW, libmonitor from Rice, and PAPI from UTK. Open|SpeedShop is an open source multi platform Linux performance tool which is targeted to support performance analysis of applications running on both single node and large scale Intel, AMD, ARM, Intel Phi, PPC, GPU processor based systems and on Blue Gene and Cray platforms.
https://www.openspeedshop.org
Other
25 stars 10 forks source link

Options not listed in install-tool help [2.3.1-rc1 on Sourceforge] #2

Closed ohearnk closed 6 years ago

ohearnk commented 7 years ago

Several of the --skip-*-build options are not listed when install-tool --help is invoked (e.g., --skip-sqlite-build, --skip-xercesc-build). The logic is there in the script for these options, so this is an easy fix.

Also, there is not an option to skip building cmake. There is no logic for this in the install-tool script, so this would involve a bit of work to add.

jgalarowicz commented 7 years ago

This is fixed in 2.3.1-rc2 on sourceforge. Let me know if it works for you. Thanks Jim G.

ohearnk commented 7 years ago

Thanks for the quick fix. The options work on my system, including --skip-cmake-build when --build-compiler gnu is set.

However, if building CMake is enabled and --build-compiler intel is set, the CMake build does not use the Intel compilers but instead uses GCC. On my machine, the Intel compilers are earlier in my shell search path than the GCC compilers. So, I'm guessing this has something to do with bootstrapping for CMake.

jgalarowicz commented 7 years ago

I may not have added the Intel compiler for cmake support. I can change that. Jim G

On 08/17/2017 04:38 PM, ohearnk wrote:

Thanks for the quick fix. The options work on my system, including --skip-cmake-build when --build-compiler gnu is set.

However, if building CMake is enabled and --build-compiler intel is set, the CMake build does not use the Intel compilers but instead uses GCC. On my machine, the Intel compilers are earlier in my shell search path than the GCC compilers. So, I'm guessing this has something to do with bootstrapping for CMake.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenSpeedShop/openspeedshop/issues/2#issuecomment-323201606, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmdtYP1F2RaFem7k49yVJ2i441s6eXGks5sZLLbgaJpZM4O3ly8.

jgalarowicz commented 7 years ago

If you don't want to wait, this might work in .support_for_install.sh at around line 2287 add the bold lines. I think this should work. I don't have an intel compiler available at the moment to test it.

if [ $1 == 1 ] ; then
    export CMAKE_INSTALL_PATH=$CBTF_CMAKE_ROOT
else
    export CMAKE_INSTALL_PATH=$KRELL_ROOT_PREFIX/cmake-$cmakever
    export KRELL_ROOT_CMAKE_ROOT=$KRELL_ROOT_PREFIX/cmake-$cmakever
fi

On 08/17/2017 04:37 PM, Jim Galarowicz wrote:

I may not have added the Intel compiler for cmake support. I can change that. Jim G

On 08/17/2017 04:38 PM, ohearnk wrote:

Thanks for the quick fix. The options work on my system, including --skip-cmake-build when --build-compiler gnu is set.

However, if building CMake is enabled and --build-compiler intel is set, the CMake build does not use the Intel compilers but instead uses GCC. On my machine, the Intel compilers are earlier in my shell search path than the GCC compilers. So, I'm guessing this has something to do with bootstrapping for CMake.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenSpeedShop/openspeedshop/issues/2#issuecomment-323201606, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmdtYP1F2RaFem7k49yVJ2i441s6eXGks5sZLLbgaJpZM4O3ly8.

jgalarowicz commented 7 years ago

I just put 2.3.1.rc3 on sourceforge. It has the above change in .support_for_install.sh. There are other changes that I'm trying to get to another person for building on a Cray, so I put this fix in as well. Jim G