OpenSprinkler / OpenSprinkler-App

A mobile interface for the OpenSprinkler irrigation device. Designed to allow manual control, program management (preview, add, edit, and delete), initiation of a run-once program, viewing graphical and tabulated representations of log data, viewing device status, adjusting rain delay, and changing of OpenSprinkler settings.
https://opensprinkler.com
GNU Affero General Public License v3.0
168 stars 91 forks source link

"IP" and "Use SSL" fields should be unified into an "URL" field #127

Open gerdneuman opened 3 years ago

gerdneuman commented 3 years ago

I have my OS running under an URL like "https://domain.com:99999/os/". I entered this into the "IP" field which did not work. I took my quiet some time to figure out the I had to enter the domain+port+path into the "IP" field (mostly by trial'n'error and searching the forum), but not the protocol (https) part.

Instead of the "IP" and "Use SSL" fields there should be one single URL field where I could just have entered "https://domain.com:99999/os/".

When implementing the existing installations (configurations) should be migrated to the new URL field when upgrading the app. That is, if "Use SSL" is ticked then prefix the "IP" field with "https://" (otherwise just "http://") for creating the new "URL" field.

salbahra commented 1 year ago

This is a great idea and would welcome a PR, if you have the time.

Otherwise, I'll see when I can add such a feature myself.

Thank you for the suggestion!