search

OpenSprinkler / OpenSprinkler-App

A mobile interface for the OpenSprinkler irrigation device. Designed to allow manual control, program management (preview, add, edit, and delete), initiation of a run-once program, viewing graphical and tabulated representations of log data, viewing device status, adjusting rain delay, and changing of OpenSprinkler settings.
https://opensprinkler.com
GNU Affero General Public License v3.0
168 stars 91 forks source link

Missing www/js/app.js file #142

Closed yeltnar closed 5 months ago

yeltnar commented 5 months ago

www/js/home.js referes to an app.js file. https://github.com/OpenSprinkler/OpenSprinkler-App/blob/7cd962c229d06deab9b3e30f8a0a15cde95d14ed/www/js/home.js#L129

However, this file is not present, preventing the UI from loading.

rayshobby commented 5 months ago

This file is automatically generated when you build app from the UI. If you run the UI in a browser window it does not require app.js

yeltnar commented 5 months ago

When loading https://demo.opensprinkler.com/, app.js is requested from /js/app.js shown in the developer tools. I find this to be the same when making the request to the local hardware.

Could you help me understand where this file comes from? This seems to disagree from your reply regarding the browser.

salbahra commented 5 months ago

You are correct and this used to be a part of the build process. We updated it recently to stop doing that (https://github.com/OpenSprinkler/OpenSprinkler-App/commit/5c609164e1e2f5654a858f48d9f148e5f760c4e0) and have not updated demo UI since that update so it's still serving the app.js.

salbahra commented 4 months ago

Just wanted to let you know this issue has been closed by updating home.js to reference the individual js files correctly now. I have also removed app.js from the backend/server.