search

OpenSprinkler / OpenSprinkler-App

A mobile interface for the OpenSprinkler irrigation device. Designed to allow manual control, program management (preview, add, edit, and delete), initiation of a run-once program, viewing graphical and tabulated representations of log data, viewing device status, adjusting rain delay, and changing of OpenSprinkler settings.
https://opensprinkler.com
GNU Affero General Public License v3.0
169 stars 93 forks source link

Add workflows for updating Firebase hosting #164

Closed salbahra closed 4 days ago

salbahra commented 6 days ago

Changes Proposed

Demo Video or Screenshots

Please include a short video or screenshot(s) to assist with pr review

github-actions[bot] commented 6 days ago

Visit the preview URL for this PR (updated for commit 563ac6c):

https://opensprinkler-betaui--pr164-feature-add-gh-actio-rjz2b45d.web.app

(expires Tue, 03 Dec 2024 02:58:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5badd5d886640bd8f8f235f7c51b83a6c0057789

mellodev commented 5 days ago

Forgot to mention, the github-actions comment link to the preview URL is 404

salbahra commented 4 days ago

I love this idea!

I'm a bit skeptical on auto merging every PR to the beta site. If a bad/broken PR is sent, what prevents it from auto deploying and completely breaking the beta site? Does it deploy to the betaui site, or a new temporary site? If it's a throw away site, then I'm on board!

One suggestion that might help here would be to create a permanent/protected beta or develop branch. PRs could merge to the new branch after review/approval, the 2nd workflow can be updated to auto deploy to the beta site only on a merge to the new branch. After a testing phase on the beta site, we can merge that branch to master for final release and auto deploy

I agree, I removed the channel therefore it will always be a temp deployment, if I am not mistaken. Great feedback, thank you!