OpenSprinkler / OpenSprinkler-Firmware

OpenSprinkler Unified Firmware for OpenSprinkler, OpenSprinkler Pi, and OpenSprinkler Beagle.
http://www.opensprinkler.com
GNU General Public License v3.0
475 stars 286 forks source link

Firmware 2.2.1 rev0 fails to import saved config JSON correctly #293

Closed glennschler closed 3 months ago

glennschler commented 3 months ago

I have upgraded from 2.2.0 rev1 to 2.2.1 Before I upgraded, I exported my JSON configuration. When I imported I did not see my stations. Only the station # 1 is still named. Reboots and re-imports did not resolve.

To resolve I edited my original JSON configuration adding the new options that a json diff shows when comparing a 2.2.1 firmware JSON configuration file. Importing the edited config resolved the issue.

{"options":
  {"fwire":0,
   "resv1":0,
   "resv2":0,
   "resv3":0,
   "resv4":0,
   "resv5":0,
   "resv6":0,
   "resv7":0,
   "resv8":0
  }
}
rayshobby commented 3 months ago

I can't reproduce the issue. What hardware platform do you have? I am not sure why adding those new options values helped -- the firmware never requires those values, if they do not exist in the import they will simply be ignored, so I am not sure why adding those mattered. Also, I assume you made a typo: the last closing parentheses should be a closing curly bracket otherwise it would not be correct json.

glennschler commented 3 months ago

Hardware OpenSprinkler 3.2 DC-powered

Yes I must have had a typo when I manually typed those new Options here in the issue description. When I have time I will factory reset to see if I can reproduce the issue.

glennschler commented 3 months ago

I am not able to reproduce this issue on a second OS 3.0 device from year 2018. I am not prepared to retest on the OS 3.2 device which experienced the original problem. I will close as not able to reproduce.