OpenSprinkler / OpenSprinkler-Weather

OpenSprinkler weather service used to calculate watering scale for the OpenSprinkler Unified Firmware.
https://opensprinkler.com
63 stars 38 forks source link

eTO adjustment logic #108

Closed rmloeb closed 3 years ago

rmloeb commented 3 years ago

I need to understand whether with a multi-zone program the eTO adjustment factor is applied to the entire program at initiation or to each zone as it's started. In other words, is the time adjustment determined when a program starts or when each zone starts?

rmloeb commented 3 years ago

Different approach: I want to turn on caching, even though I'm using a PWS. That will assure a constant weather adjustment throughout the day. I believe I can make that happen by modifying the following code in Weather,ts, but I would appreciate confirmation of that.

// Cache the watering scale if caching is enabled and no error occurred. if ( weatherProvider.shouldCacheWateringScale() ) { cache.storeWateringScale( req.params[ 0 ], coordinates, pws, adjustmentOptions, { scale: data.scale, rawData: data.rawData, rainDelay: data.rd } ); }

Rationale: I want to accumulate the eTO adjustment across multiple days and then either zero it or push the total into OpenSprinkler just before the first watering program runs. This would allow eTO to work properly when not watering every day.