search

OpenSprinkler / OpenSprinkler-Weather

OpenSprinkler weather service used to calculate watering scale for the OpenSprinkler Unified Firmware.
https://opensprinkler.com
63 stars 38 forks source link

Fixing issues with the OWM weather service after their recent changes… #121

Closed cubiczar closed 2 years ago

cubiczar commented 2 years ago

… to the free API. Resolves #122

salbahra commented 2 years ago

Thank you for the pull request! I will try to review this ASAP and get it merged if everything looks good.

Thanks again!

cubiczar commented 2 years ago

Looks like only part of this is working, I need to do some more testing, fixed one issue and thought I was good but I'm running into some other errors now after letting it run for longer. Going to close this will open a new one once I track down the issues.

cubiczar commented 2 years ago

Alright should be fixed now, not sure how I missed the return statement there but looks good now. I've tested both the weather1.py url and the WeatherData url to verify this time around. Also it's showing up correctly in the OpenSprinkler app as online so think it's fixed now.

garudaonekh commented 2 years ago

It looks to be working fine for me.

cubiczar commented 2 years ago

No worries, life happens, just glad to be able to contribute.

On Sun, May 15, 2022, 5:49 PM Samer Albahra @.***> wrote:

@.**** approved this pull request.

Apologies for the delay but approved!

— Reply to this email directly, view it on GitHub https://github.com/OpenSprinkler/OpenSprinkler-Weather/pull/121#pullrequestreview-973311935, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAP6WUPV2634PNKPOPJBWG3VKGLSHANCNFSM5FPVM2HA . You are receiving this because you modified the open/close state.Message ID: @.*** com>