search

OpenSprinkler / OpenSprinkler-Weather

OpenSprinkler weather service used to calculate watering scale for the OpenSprinkler Unified Firmware.
https://opensprinkler.com
63 stars 38 forks source link

Create weatherProvider/utils.ts #64

Closed PeteBa closed 5 years ago

PeteBa commented 5 years ago

Consider moving helper functions from eto adjustment method to Weather Provider helper. Reduces scope of imports.

It's not currently being used (it will be used when getEToData is implemented in WeatherProviders). Adding a dedicated utils file sounds like a great idea, but let's do that in a separate PR so we can move some other functions from weather.ts into there without changing the scope of this PR too much

Originally posted by @Derpthemeus in https://github.com/OpenSprinkler/OpenSprinkler-Weather/pull/62

PeteBa commented 5 years ago

I'm closing this one as it is partly coding style. Can also wait to the next big refactor in 3.0 ! Feel free to re-open if you feel more of a priority.