search

OpenSprites / OpenSprites-Origin

The original OpenSprites website, written in PHP. Discontinued - remains for historical reasons. See OpenSprites-Next for the new generation of Scratch resource sharing.
MIT License
19 stars 9 forks source link

Refactoring of many things #174

Closed robinp7720 closed 9 years ago

robinp7720 commented 9 years ago

Trust me. This is better. Probably still a few mistakes in the re-factoring. You guys have really gotta give contributes a way to setup the database

towerofnix commented 9 years ago

No - why delete OpenSprites is Illuminati.mp3? :(

jamesd-uk commented 9 years ago

Lets not be hasty now. ;)

matthewr6 commented 9 years ago

"only experienced php programmer" hey @MegaApuTurkUltra want to have some fun here :P

None of this is really a "refactor" - it's mostly messing w/file positions.

matthewr6 commented 9 years ago

I don't dislike you as a person. I, and others, dislike your attitude.

matthewr6 commented 9 years ago

It is with that attitude.

Bye then.

MegaApuTurkUltra commented 9 years ago

@robinp7720 Your refactor and clean up is great except for one thing: you formatted library code which should have stayed minified. Just make sure to format only non-library code and we could accept your PR.

And yes, a lot of the code is messy and everything. Classes might be nice but using classes in PHP is kind of annoying.

I also am the only experienced php programmer here (As far as I can tell). You want me, trust me.

Let's not jump to conclusions. Remember that you're trying to make a case for why your PR should be accepted. Don't assume that we want your code really badly or anything, because we don't.

matthewr6 commented 9 years ago

thx