search

OpenSprites / OpenSprites-next

(shelved) OpenSprites - Share your Scratch scripts, costumes, sprites and sounds with the community!
MIT License
16 stars 5 forks source link

Set up email #6

Open jamesd-uk opened 8 years ago

jamesd-uk commented 8 years ago

Email addresses for general contact us, email verification, and DMCA hotline.

bates64 commented 8 years ago

Also for verifying email addresses, I assume? :package:

bates64 commented 8 years ago

Our policy should probably be like Scratch - you can make an account but until your email is verified you can't upload resources.

jamesd-uk commented 8 years ago

Ruling out sendgrid because it wants my life story

jamesd-uk commented 8 years ago

Sendgrid approved my account O_o

I just need info from @nanalan

bates64 commented 8 years ago

info

Such as?

Also I'm hoping to use some sort of .env and gitignored file to save api keys and the like - thoughts @MegaApuTurkUltra @liam4?

towerofnix commented 8 years ago

API keys?

Btw obviously hashed right?

matthewr6 commented 8 years ago

Just store it in an environment variable.

Or actually almost anything but on a git repo :P

MegaApuTurkUltra commented 8 years ago

+1 for environment variables. dotenv is now in package.json so we can easily do environment vars on our local copies

Just don't remove .env from .gitignore :P

MegaApuTurkUltra commented 8 years ago

Any progress on this?

I guess it blocks the "forgot password" feature of #84

jamesd-uk commented 8 years ago

I have a SendGrid account set up, I'm just waiting for someone to ask me for API keys.

bates64 commented 8 years ago

I have a SendGrid account set up, I'm just waiting for someone to ask me for API keys.

asks

bates64 commented 8 years ago

I've implemented SendGrid in a84fd4f7d6b268bececa5830851dcb1101284f05 - you can send emails now, but somebody needs to make/get a cross-client email template...

bates64 commented 8 years ago

@MegaApuTurkUltra email template pls

MegaApuTurkUltra commented 8 years ago

We should do the template in handlebars. Can handlebars render to string?

bates64 commented 8 years ago

yep, it can render anything (not just html).

MegaApuTurkUltra commented 8 years ago

Just set up templating - see https://github.com/OpenSprites/OpenSprites-next/blob/master/server/utils/email.js#L44-L65

Currently an html version and a text version are templated and sent.

I haven't actually tested sending an email though, for lack of a sendgrid api key.