OpenSrcerer / supersonic

A bot for Discord that allows you to stream music through a subsonic server.
GNU General Public License v3.0
20 stars 3 forks source link

openSonic not recognized error #20

Open iGieri opened 6 months ago

iGieri commented 6 months ago

Started with docker-compose.

I have a navidrome instance.

This is the output when I try the "/play" command:

java.io.IOException: Unrecognized field "openSubsonic" (class personal.opensrcerer.responses.search.Result3), not marked as ignorable (8 known properties: "status", "serverVersion", "version", "type", "xmlns", "time", "searchResult3", "error"])

deluan commented 6 months ago

Navidrome developer here. This was caused by the introduction of new attributes in Subsonic responses.

Navidrome joined OpenSubsonic, a joint effort of clients and servers to evolve the original Subsonic API (now basically unmaintained), and bring more features to it.

The quick solution to this issue here is supersonic (and any Subsonic clients for that matter) to be more lenient, and ignore any unknown attributes. You can see from the docs above and from our discussions that lots of new attributes are being introduced, and if a client choses to validate all of them, it will be a lot of work to keep up with every new addition.

OpenSrcerer commented 5 months ago

Thanks @deluan, perfectly said. Until the OpenSubsonic API situation stabilizes, it's difficult to cope with the changes. As such I do not plan to update this project until such a point is reached.

deluan commented 5 months ago

Thanks @deluan, perfectly said. Until the OpenSubsonic API situation stabilizes, it's difficult to cope with the changes. As such I do not plan to update this project until such a point is reached.

Well, it will never be really "stable". Making your client ignore unknown attributes would allow it to work with any Subsonic server, OpenSubsonic or not, even if you don't ever implement any OS features. Just my 2 cents...