OpenStickCommunity / GP2040-CE

Multi-Platform Gamepad Firmware for Raspberry Pi Pico and other RP2040 boards
https://gp2040-ce.info
MIT License
1.52k stars 335 forks source link

Addons with migrated GPIO do not correctly update Pin Mapping #1220

Open mikepparks opened 3 days ago

mikepparks commented 3 days ago

It seems that with the new Pin Mapping functionality to allow multiple actions per pin, GPIO migration does not properly occur from previous versions.

To repro, assume an upgrade to #1216 and attempt the following.

Expectation: A GpioAction::ANALOG_DIRECTION_MOD_LOW definition should be assigned in Pin Mapping to the Pin previously defined in Tilt 1.

Issue: The Pin in Pin Mapping remains GpioAction::ASSIGNED_TO_ADDON and cannot be unassigned. The previous value in the addon itself is not updated in the proto data.