OpenStickCommunity / GP2040-CE

Multi-Platform Gamepad Firmware for Raspberry Pi Pico and other RP2040 boards
https://gp2040-ce.info
MIT License
1.53k stars 337 forks source link

Enabling Reverse Input Button Breaks SOCD #822

Closed tomatosoupcan closed 8 months ago

tomatosoupcan commented 10 months ago

Prerequisites

Please check the following before posting an issue / bug report.

Context

Please provide all relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Expected Behavior

When turning on the addon for Input Reverse, pressing the button should reverse the input as defined in the reverse input rules. Additionally, existing functionality should not be impacted when this button/mode is active.

Current Behavior

When the addon for Input Reverse is enabled, all SOCD modes break. All buttons can be held down at any time without SOCD cleaning. This is irrespective of the Input Reverse button being pressed.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Set SOCD cleaning mode to any mode other than "Off"
  2. Reboot device and see that SOCD presses are properly handled
  3. Enable a button for Input Reverse
  4. Reboot device and see that SOCD presses are not properly handled
TheTrainGoes commented 10 months ago

Thank you for the report @tomatosoupcan ,

We are aware of this issue.