OpenSwiftUIProject / OpenSwiftUI

[WIP] Open source implementation of Apple's SwiftUI.
https://swiftpackageindex.com/OpenSwiftUIProject/OpenSwiftUI/main/documentation/openswiftui
MIT License
912 stars 27 forks source link

Bug: Fix flag name typo #63

Closed SunburstEnzo closed 4 months ago

SunburstEnzo commented 4 months ago

What

I noticed the flag in the Example project was using OEPNSWIFTUI instead of OPENSWIFTUI

How

Changed the flag name in Build Settings and ensured it was changed everywhere else (only ViewController.swift from what I could tell)

Screenshot 2024-04-06 at 2 24 59 pm

Let me know if I missed anything!

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 13.42%. Comparing base (2b0da4d) to head (4056f2a).

:exclamation: Current head 4056f2a differs from pull request most recent head 5a62b58. Consider uploading reports for the commit 5a62b58 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #63 +/- ## ======================================= Coverage 13.42% 13.42% ======================================= Files 185 185 Lines 4357 4357 ======================================= Hits 585 585 Misses 3772 3772 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Kyle-Ye commented 4 months ago

The repo requires all commits to be signed. You need to recommitting the commits and force push to solve it.

See more info here https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Kyle-Ye commented 4 months ago

Still showing as "Unverified". Maybe you need to upload your GPG key to your GitHub account.

image

Kyle-Ye commented 4 months ago

I've cherry-picked your changes and will merge this in #67. (Reserving you as the commit author)

Close this PR. Sorry for that.

SunburstEnzo commented 4 months ago

No problem at all and apologies for the delay – should now show as Verified hopefully

Screenshot 2024-04-06 at 3 57 17 pm