search

OpenTSDB / opentsdb

A scalable, distributed Time Series Database.
http://opentsdb.net
GNU Lesser General Public License v2.1
5k stars 1.25k forks source link

Use ConcurrentHashMap when serializing tags. #2282

Closed bshakur8 closed 1 year ago

bshakur8 commented 1 year ago

fix OpenTSDB#1055

manolama commented 1 year ago

Good catch, thanks!

ugtar commented 1 year ago

I'm sorry @manolama, @bshakur8 changed this PR to a draft earlier today because we had a reproduction even with this patch. It may have reduced the frequency, but it's not a fix

manolama commented 1 year ago

NP, thanks @ugtar it does help like you said. There can still be silent failures, I believe, in the tag resolutions deferreds. https://github.com/bshakur8/opentsdb/blob/78fb1fad8bc885a028bce6abdd2c4c2e62a99f29/src/tsd/HttpJsonSerializer.java#L916-L923 Try attaching some explicit error callbacks there.

ugtar commented 1 year ago

alright, well, in any case I think unfortunately #1055 needs to be reopened :confounded: