search

OpenTSDB / tcollector

Data collection framework for OpenTSDB
http://opentsdb.net
GNU Lesser General Public License v3.0
513 stars 359 forks source link

HadoopHttp library class doesn't recurse JSON fields, misses metrics #393

Closed HariSekhon closed 4 years ago

HariSekhon commented 6 years ago

HadoopHttp library class doesn't recursely walk the JMX JSON properly for Hadoop / HBase and therefore doesn't extract all the metrics.

For example it doesn't extract LastGCInfo duration which is really important for monitoring GC Pause times (GCTimeMillis just doesn't cut it), since the 'value' of the field is json it fails the is_numeric() check from utils and skips it entirely:

  }, {
    "name" : "java.lang:type=GarbageCollector,name=G1 Young Generation",
    "modelerType" : "sun.management.GarbageCollectorImpl",
    "LastGcInfo" : {
      "GcThreadCount" : 24,
      "duration" : 265,

This will affect all the Hadoop and HBase plugins.

HariSekhon commented 6 years ago

Looks like there is a patch pull request in #375 since last Oct but nobody has reviewed it.