search

OpenTSDB / tcollector

Data collection framework for OpenTSDB
http://opentsdb.net
GNU Lesser General Public License v3.0
513 stars 359 forks source link

Python 2.6, 2.7, 3.4, 3.5, 3.6, 3.7 compatibility #395

Closed xavierhardy closed 5 years ago

xavierhardy commented 6 years ago

This pull request brings compatibility from Python 3.4 to Python 3.7 included (await is keyword in 3.7).

xavierhardy commented 6 years ago

Related to issue #218

johann8384 commented 5 years ago

This is great! I did some work on this as well, and did some refactoring to make testing easier. I'll rebase mine to work off this, you went through more collectors than I had gotten to.

johann8384 commented 5 years ago

Can you add the additional Python version to the Travis build in your branch? Then we can see that is passes with all the versions for your PR.

https://github.com/OpenTSDB/tcollector/blob/master/.travis.yml#L3

Thank you !!

johann8384 commented 5 years ago

Merged in #411

xavierhardy commented 5 years ago

Thanks for merging and adding the Python 3 environments to Travis.