Fix memory leak around timestamp precision adjust

OpenTSDB / tcollector

Data collection framework for OpenTSDB

http://opentsdb.net

GNU Lesser General Public License v3.0

513 stars 359 forks source link

Closed cheynearista closed 6 years ago

cheynearista commented 6 years ago

Global MAX_REASONABLE_TIMESTAMP adjusted in error. Due to arbitrary precision arithmetic, over time memory can be seen leaking for lines processed with ms precision timestamps. Set/adjust local copy max_reasonable_timestamp within scope of function.
Perform timestamp precision check before converting timestamp to int to save allocation of buffer.
Replace space normalization looping construct with split/join.

cheynearista commented 6 years ago

@OpenTSDB Can I get a set of eyes on this?

tsuna commented 6 years ago

LGTM, thanks for the fix!