search

OpenTTD / OpenMSX

Music Base Set for OpenTTD
GNU General Public License v2.0
22 stars 12 forks source link

Fix: Support Python 3 #2

Closed steils closed 4 years ago

matthijskooijman commented 4 years ago

Also: For the Debian package, I would be interested in having this fixed in a release. Debian is planning to drop support for Python2, so I'd rather switch to Python3 soon to support the Python2-removal process.

steils commented 4 years ago

Sorry for the mistake I made in the initial PR. Anyway, @LordAro @planetmaker could you please review and accept it?

LordAro commented 4 years ago

Sorry, this repo doesn't (yet) have notifications set up in the same way as the other repos, so changes can get lost.

Why have you replaced indentation with tabs? Should be 4 spaces everywhere, surely?

steils commented 4 years ago

@LordAro Didn't know about your coding style. Just saw a mix of tabs and spaces. Changed everything to tabs for consistensy (not 4 spaces because of habit). I'll change everything to 4 spaces, if it is a preferred style, of course.

LordAro commented 4 years ago

Not exactly surprising, the rest of OTTD (C/C++) uses tabs, there was some overlap back in the old days.

These days it's PEP8 or GTFO ;)

steils commented 4 years ago

Changed tabs to spaces, force-pushed