search

OpenTTD / OpenMSX

Music Base Set for OpenTTD
GNU General Public License v2.0
22 stars 12 forks source link

No tests (make check) is possible #22

Open ConiKost opened 3 years ago

ConiKost commented 3 years ago

Hi! It seems, that 'make check' cannot be executed, as files? seems to be missing.

Basically, make check will always fail: /usr/bin/grfid -m openmsx.grf > openmsx.md5 Unable to get requested information: Unable to open file

The problem is, the .grf is never created. If I try to run manually make grf, it will also fail, because it complains of missing openmsx.pnml

[CPP] openmsx.nml
cc -D REPO_REVISION=0 -D NEWGRF_VERSION=0  -C -E -nostdinc -x c-header -o openmsx.nml openmsx.pnml
cc1: fatal error: openmsx.pnml: No such file or directory
compilation terminated.

I am not sure, is it missing or does it has to be created somehow? I can't find anything realated about creation in the Makefile.

glx22 commented 3 years ago

OpenMSX is not a newgrf, so none is created. But it uses the same Makefile as other projects.

ConiKost commented 3 years ago

So basically make check is here a no-op, as it won't work anyway?

matthijskooijman commented 3 years ago

I also ran into this issue, see #30 for a list of this and some other build system issues. I'm not sure if make check was ever useful, since I suspect it's not used for multiplayer compatibility like grfs/OpenGFX?