OpenTTD / OpenMSX

Music Base Set for OpenTTD
GNU General Public License v2.0
22 stars 12 forks source link

MIDI File Fixes for Technical Errors #24

Open curioustorvald opened 3 years ago

curioustorvald commented 3 years ago

Related issue: #17

This commit fixes so-called "music is distorted but sometimes" bug observed on Windows, caused by some songs changing MIDI Pitch Bend ranges but it's not being reverted.

In other words, I just added bend range reset commands on every single MIDI file so that they are properly initialised.

Ideally this should be fixed by the sequencer itself — they should reset any parameter changes from previous songs — but it seems Windows MIDI sequencer doesn't do that, and since Microsoft actually fixing any music-related bugs on their product is simply something that would never happen, I thought it would be better to "fix" the MIDI file themselves.