Replace outdated Mercurial stuff, update README

OpenTTD / OpenMSX

Music Base Set for OpenTTD

GNU General Public License v2.0

22 stars 12 forks source link

Replace outdated Mercurial stuff, update README #7

Closed Wuzzy2 closed 3 years ago

Wuzzy2 commented 3 years ago

Fixes #5. Fixes #6.

This PR updates the README and fixes many outdated instructions, links and references to Mercurial-related stuff to replace it with Git-related stuff.

This PR also updates the Makefiles and .hgignore.

Wuzzy2 commented 3 years ago

Please test if it still builds for you without error! That's really important. :D

orudge commented 3 years ago

I haven't tested this, but given there were issues with the equivalent changeset on OpenSFX, I suspect we'll basically need to copy those same changes over. Also the appropriate GitHub Actions infrastructure.

Wuzzy2 commented 3 years ago

I've looked at the script again, and and OpenSFX, and made the following changes:

Generate proper bundle name with version number attached (based on Git tag), fix version number in README
Add findversion.sh
Fixed unix2dos detection (identical bug in OpenSFX)

As for GitHub Actions, I suggest to do this stuff separately (different PR).

planetmaker commented 3 years ago

I just pulled the branch and tried to build it, yet it failed. ~/ottd/OpenMSX] kill-hg(+1/-0) 2 ± LC_ALL=C make Makefile:161: *** unterminated call to function 'shell': missing ')'. Stop.

The problem here is case: shell is not the same as SHELL

you should use consequently SHELL (that also fits the style guide that variables are UPPERCASE)

LordAro commented 3 years ago

No? Well, kinda, but not quite. $(shell ...) is the function, SHELL is the variable that sets the shell to use. Is /bin/bash not valid on your system, I wonder? (This also seems very similar to Eddi's OpenTTD/grfcodec#11 )

https://www.gnu.org/software/make/manual/html_node/Shell-Function.html https://www.gnu.org/software/make/manual/html_node/Choosing-the-Shell.html

Wuzzy2 commented 3 years ago

Well, it works for me. *shrug*

orudge commented 3 years ago

If in doubt, just copy what already works (OpenSFX). :)

The whole lot should be squashed into a single commit, but that can be done at merge time. I'll have a look at the rest of the changes.

Wuzzy2 commented 3 years ago

I agree all the commits should be squashed at the end, but not now, before the review/approval is done.