search

OpenTTD / OpenSFX

Sound Base Set for OpenTTD
Other
15 stars 11 forks source link

Make sounds for "unused" empty sounds? #18

Closed Wuzzy2 closed 3 years ago

Wuzzy2 commented 3 years ago

Currently, there are two empty sounds in OpenSFX: osfx_34.wav (SND_22_CAR_HORN) and osfx_50.wav (SND_32_POP_2).

Those sounds are not used in OpenTTD so far (1.10.0), according to looking at the source code. (Here's an overview btw: https://wiki.openttd.org/en/Development/SoundIDs). So it is currently perfectly OK that both sounds are empty.

But would it make sense to create sound files for those two, just in case that support for OpenTTD is added later? It seems like the first one is meant for a car horn, and the second one is meant for an 'alternative' bubble pop sound for the Toyland bubble generator.

See also: https://github.com/OpenTTD/OpenTTD/issues/8619

frosch123 commented 3 years ago

NewGRF can add their own sounds.

Wuzzy2 commented 3 years ago

You're sidestepping the issue. This is not about neccessarily inventing new sounds. It's about sound IDs that are OFFICIALLY defined in OpenTTD, but are currently unused for some reason. I also still have not gotten an answer on the other issue whether these sounds are really meant to be unused or if it's a bug/oversignt. If these sound IDs are intentionally unused, then this issue is moot, and can be closed. But if these sound IDs were meant to be actually used officially, just haven't been implemented for some reason, then I think this issue is valid.

Wuzzy2 commented 3 years ago

So I was told the sounds are intentionally unused. This means this issue is now moot.