OpenTTD / OpenSFX

Sound Base Set for OpenTTD
Other
15 stars 11 forks source link

Fix: Swap modern/old bus sounds #32

Closed Wuzzy2 closed 3 years ago

Wuzzy2 commented 3 years ago

Whoops! I just noticed the sounds for modern bus and old bus were swapped. (no. 27 and 28) Meaning the sound that should be for the modern bus is actually and old bus sound, and vice-versa. You can test this in Temperate climate with the Hereford Leopard Bus (should be 'old bus' sound) and the Foster Bus (should be 'modern bus' sound).

Look into src/sound_type.h and src/table/engine.h in OpenTTD for reference, here you can clearly see the sounds in OpenSFX are swapped (so I am not just imagining this problem ;-) )

This PR fixes this by swapping both sounds, so they are correct. Note these sounds were swapped since forever (I tested this in older versions of OpenSFX/OpenTTD), this has nothing to do with my recent OpenSFX “liberation”.

I noticed this while looking at the newly reworked file src/sound_type.h in OpenTTD.

Wuzzy2 commented 3 years ago

In this PR I also updated the other sound descriptions to be consistent with src/sound_type.h.

orudge commented 3 years ago

I will take a look at this when I get a chance - can look at doing a 1.0.1 release then if necessary.

Wuzzy2 commented 3 years ago

Yes. Besides, I think a new release would make sense anyway once OpenSFX has piled up a couple of new translations. ;-)

planetmaker commented 3 years ago

Did the requirements for a release change? Previously it just needed tagging and the build system did the rest. And then the build artefact was uploaded to bananas once confirmed build showed correctly ingame.

orudge commented 3 years ago

@planetmaker No, that's all that needs doing now. The changelog, etc, of course needs to be updated manually first.

Wuzzy2 commented 3 years ago

To be clear: I am fine with a quick bugfix release for this, even if it does not include new translations. It's always possible to do another release once enough translations have arrived.

LordAro commented 3 years ago

Now that translations are automated, best to just cut a release just before doing the "main" OTTD release