search

OpenTTD / eints

WebTranslator for OpenTTD and its add-ons
GNU General Public License v2.0
6 stars 10 forks source link

Change: Language list now links to language inside projects #99

Closed Bouke closed 1 year ago

Bouke commented 1 year ago

The UI's menu prominently lists "Languages" as a top-level menu item. Clicking a language from that page it shows the projects for that language. Then after clicking a project, I would expect to arrive at the overview page of that language for that project, however that currently navigates to the project page and I have (yet again) select the language I want to translate.

This PR changes that by eliminating this last step.

I haven't verified whether this change actually works, as I don't have a local checkout / working environment. Based on the template variables it seems fine to me, but needs an additional pair of eyes.

glx22 commented 1 year ago

I like the idea and the change seems correct.

Bouke commented 1 year ago

Is there anything pending on me? The PR checker wants me to change the commit title, I can do that. How about this?:

Change: Deeplink to language inside project

glx22 commented 1 year ago

We can fix the commit message on merge.