Open stormcone opened 1 year ago
Hmm order of events is annoying, builtin validation happens during parsing, while populating the tables happens during preprocessing.
It think the issue started with https://github.com/OpenTTD/nml/commit/93c8cfca515f9fdeecb5aafb60267d1cc88b1237 for cargotable, and with https://github.com/OpenTTD/nml/commit/1070b5d81ce24d9c3520bf942d4d3c1a99e05cde for railtypetable.
Named parameters seem to have a similar issue when used as 3rd and 4th arguments of item
. They don't exist before preprocessing but item
checks for them during parsing.
There is a topic on the forum that the cargotype function does not work: https://www.tt-forums.net/viewtopic.php?t=90428
I did some test and looks like that in
functioncall.py
the global constant tables are empty if the tables defined by the nml file: https://github.com/OpenTTD/nml/blob/bbe945ed348dfe19d284908983c8bb55e0d840ad/nml/expression/functioncall.py#L480C1-L485I put the following commands after line 494:
If I define the cargotable and the railtypetable, then that is the output:
So looks like the tables are empty. If I do not define the railtypetable, the second table is not empty:
Version
Expected result: The attached nml file can be compiled
Actual result: nmlc ERROR: "test.nml", line 16: Parameter for railtype() must be a string literal that is also in your railtype table
Steps to reproduce:
nmlc test.nml
Output: nmlc ERROR: "test.nml", line 16: Parameter for railtype() must be a string literal that is also in your railtype tableEdit the test.nml: comment out the railtypetable:
// railtypetable { RAIL, ELRL, MONO, MGLV }
nmlc test.nml
Output: nmlc ERROR: "test.nml", line 24: Parameter for cargotype() must be a string literal that is also in your cargo tableComment out the cargotable and the cargotype_available if statements too:
nmlc test.nml
Output: nmlc info: 0 sprites, 0 cached, 0 orphaned, 0 duplicates, 0 newly encoded (native) nmlc info: Railtype items: 1/64 nmlc info: Concurrent ActionD registers: 1/64 ("test.nml", line 14)cargo_type_test.zip