Closed zephyris closed 8 months ago
I believe Openttd supports waypoint names so it is probably a nml bug
Waypoints can have names. Possibly your version of nmlc produces a NewGRF that is incompatble with 13.x?
@PeterN Yes, you're right, OpenTTD error does not happen for the latest nightly. I guess this can be closed...
But why? Seems like a basic thing, nmlc vs. OpenTTD version sensitivity seems weird to me...
OpenTTD did https://github.com/OpenTTD/OpenTTD/commit/bc7dfd7b46c0184dc4b2cc376556702ac0ac1019 in nightlies, which has been then added to nml in 0.7.4 (but there's a bug with a fix waiting for approval in #305)
TBH I assumed nmlc would try to keep compatibility with older versions were possible, e.g. by only using the new method if the local id was >= 255.
I've tested for sanity's sake, and it is indeed action0
and 0x1C
0x1D
/name
and class_name
responsible for the OpenTTD error. I second @PeterN, for NewGRFs with few station names, retaining backwards compatibility is preferable...
I can rewrite #305
I don't think waypoints, coded as a special class of station, can have a name.
If you code a station using the
"WAYP"
class forITEM_STATIONS
and provide aname
property, then OpenTTD reports a NewGRF error:Unknown action0 property
.If you do not provide a
name
property, thennmlc
reports the errornmlc ERROR: "ogfx2_stations.nml", line XXX: Property 'name' is not set. Item will be invalid.
, but makes a functional NewGRF that OpenTTD seems happy with.Presumably just needs a special case for reporting the error? Or is this an OpenTTD bug?