search

OpenTabletDriver / opentabletdriver.github.io

The next version of OpenTabletDriver.Web
http://opentabletdriver.net/
GNU Affero General Public License v3.0
1 stars 5 forks source link

Refactor SCSS #158

Closed gonX closed 7 months ago

gonX commented 9 months ago

Darkly is still a predominantly dark-theme skin, but has small variations between dark and light mode.

A lot of color and pixel-specific settings have been removed as the stock theme is actually surprisingly close what we want. Additionally, having these was hindering correct light/dark mode display. Removing these also allows us to be more flexible with which Bootswatch themes we can use.

Many definitions have been moved around to better fit the nesting of SCSS, reducing clutter and increasing readability.

Supersedes #157 Supersedes #154 Fixes #33 Fixes #151

gonX commented 9 months ago

Some notable changes (left is new - old on the right) /Tablets table (unintentionally) lost its background: image

/Wiki: Color, sizing and spacing slightly different: image

/Wiki/Documentation/CommandLine: Sizing went crazy, table lost its background (again) image

Wiki articles (in this case /Wiki/FAQ/Linux) unintentionally has much bigger spacing now: image

gonX commented 7 months ago

Fixed table backgrounds, gonna look into the other stuff now and then merge once the styling looks (mostly) similar

gonX commented 7 months ago

New images! New on left / old on right:

Linux FAQ

image

Tablets page

Looks basically identical, so no image attached

Plugins

Minor color difference in saturated colors

image

Windows Install Guide

image

Linux FAQ mobile view

image

I personally think the sizing changes are fine and can be worked with down the line if we end up not liking them. For now, the award is that we have less custom (S)CSS to manage.