OpenTechEngine / OpenTechBFG

Engine based on (RB) Doom 3 BFG aiming to allow the creation of standalone games
Other
85 stars 11 forks source link

macOS fixes #141

Closed damiel closed 7 years ago

damiel commented 7 years ago

Tested these fixes on my local machine, a MacBook Pro 13' from 2017. Currently OTE will only build on macOS when using sdl2. See my comment in neo/sys/posix/posix_main.cpp.

damiel commented 7 years ago

Now that i use mac as my main machine i started looking for mac related issues to fix, two things i already noted are problems with Breakpad and CEGUI, i think Breakpad is just missing integration but CEGUI seems to have a build dependency problem regarding the installed boost version. It requires an old boost version which is not so easily available as like for example simply installing boost via Homebrew.

EDIT

Now that i think of it i think this wont build because we use sdl1 still per default. We either need to find a replacement for how to find the appropriate paths on macOS to store things or switch to sdl2 per default on atleast macOS.

damiel commented 7 years ago

Okay, the check succeded because of the travis settings being: allow_failures:- os: osx

I've just seen another, older pullrequest that actually already adresses the build errors on macOS so i did a bit of duplicated work here...

damiel commented 7 years ago

I will have to do some more adjustments to this until its good enough to merge. Working on it atm.

kortemik commented 7 years ago

I wonder what is the relationship to #90 as it has some stuff needed as well?

damiel commented 7 years ago

Well i plan on superseding #90 with my own pull request, i started incorporating changes from #90 that make sense like the travis integration. Once my pull request gets merged we can close #90.

damiel commented 7 years ago

Well f*ck, i found the issue, the build script get excluded by git because of a entry in .gitignores, trying to find a good compromiss here x) (Also i am stupid that i didnt saw that earlier :D)

damiel commented 7 years ago

Okay, OTE is now fully buildable on macOS/travis, thing to note is that the packaging using cpack seems to be broken for macOS at the moment, i will take care of that in a seperate pull request. I will clean up this pull request and proceed to merge it.

BielBdeLuna commented 7 years ago

congratulations! :)

kortemik commented 7 years ago

thank you damiel for finishing it!

On Wed, Oct 18, 2017 at 6:50 PM, Biel Bestué de Luna < notifications@github.com> wrote:

congratulations! :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenTechEngine/OpenTechBFG/pull/141#issuecomment-337637254, or mute the thread https://github.com/notifications/unsubscribe-auth/AA19OnoeBtwa581ujMHPaZ8hzdnxLphDks5sth4-gaJpZM4PLLwh .