OpenTechEngine / OpenTechBFG

Engine based on (RB) Doom 3 BFG aiming to allow the creation of standalone games
Other
85 stars 11 forks source link

Namespace consistency #57

Closed kortemik closed 9 years ago

kortemik commented 9 years ago

Everything should be in the BFG namespace (or a subnamespace of it). so idCEGUI should be BFG::idCEGUI, CEGUIConsole should be BFG::CEGUIConsole and BFG::CEGUIMenu..

DanielGibson commented 9 years ago

Another small style-related thing I noticed in the CEGUIMenu::MenuInterface: I think we should stick to the Doom3 standard of naming methods in UpperCamelCase (Init() instead of init(), SetVisible() instead of setVisible() etc)

BielBdeLuna commented 9 years ago

no need to keep the "id" for every name, in quake 4 sdk it helps to find the "rv" in every function Raven did, it helps to separate their functions from id's.

I myself always do my functions with "bl" so it's easier to read the code in the future.

DanielGibson commented 9 years ago

not sure if having lots of different prefixes is a good idea.. if you're looking for e.g. a classname, now you can look for id<whateveryou're searching for> - a lot more painful to also look for (or try in autocompleteion) bl<whatever>, dg<whatever>, ...

BielBdeLuna commented 9 years ago

well if you search for "whatever" in the IDE you will find both so no problem here, try to port your code changes from code base to code base and you will see it easily if we don't stick with the "id"

ghost commented 9 years ago

Or just ot

DanielGibson commented 9 years ago

fixed via #60