search

OpenTechEngine / OpenTechBFG

Engine based on (RB) Doom 3 BFG aiming to allow the creation of standalone games
Other
84 stars 11 forks source link

Renderfixes: #86

Closed damiel closed 8 years ago

damiel commented 8 years ago

This commit ports a bunch of render fixes from rbdoom3bfg to ote, including a fix for issue #83.

BielBdeLuna commented 8 years ago

great!

ghost commented 8 years ago

Thank you damiel.

DanielGibson commented 8 years ago

would it be possible to cherry pick the corresponding commits from rbd3bfg? that would probably make it easier to merge other changes later.. or are these fixes parts of bigger commits that we (mostly) don't want/need?

damiel commented 8 years ago

It depends a bit, some of the commits where mixed up with stuff that is unnecessary for us, other commits have include parts that got later reverted or add some noise (like outcommented code that isnt even is use) and some files had mismatching lines making the cherrypick fail. In this case it was just easier to port all the smaller changes in one go by being handpicked.

But i think later commits from rbd3bfg like SSAO and SMAA can be cherrypicked. (and i plan on doing so for my next pr's).

BielBdeLuna commented 8 years ago

Without those fixes, the engine can only be played with OpenGL Compat with Mesa drivers, and so you're stuck with OpenGL 3.0 on all hardware, because the GLSL changed sine that version of OpenGL that's the reason the changes in the CG files,

The problem with compat vs core profiles, is that core has been improving a lot (core currently is at OpenGL 4.3, and compat has been at 3.0 for a long time now) Maybe compat won't be any-more updated from now on? Now RBDoom3BFG uses core profile that's the reason of that update.