Changes to build under Python 3

OpenTechSchool / python-beginners

Workshop material for "Introduction to Programming with Python"

http://opentechschool.github.io/python-beginners/

175 stars 251 forks source link

Changes to build under Python 3 #90

Closed alisdt closed 2 years ago

alisdt commented 2 years ago

Small changes to conf.py so this builds under Python 3:

new syntax for exception except ( .... ) as e: rather than except ( .... ), e:
supply default system encoding to subprocess when fetching version and authors (this will be utf-8 on most systems but using getdefaultencoding() accommodates e.g. Windows code pages).

akarsh commented 2 years ago

@alisdt can you please share further information about the code compatiiblity if it is also backwards compatible with python 2?

alisdt commented 2 years ago

Thanks for considering this change. I can test but I suspect it won't build under Python 2. However, I couldn't get the docs as they are to build under Python 3 without fixing these problems. Given this, it seems better to favour the current supported version of Python.

alisdt commented 2 years ago

I can confirm that this won't build under Python 2. However, this seems reasonable now that Python 2 is no longer supported.

alisdt commented 2 years ago

I've gone in a different direction with my fork and (I'm guessing from the above comment) the maintainers prefer Python 2 for build, so I'm closing this request.