OpenTechSchool / websitenext

OpenTechSchool website
https://www.opentechschool.org
8 stars 6 forks source link

add instagram icon #148

Closed morrme closed 4 years ago

morrme commented 4 years ago

Fixes #147

Note: The instagram.com/opentechschool IG account was blank, so I used instagram.com/opentechschool_leipzig . Please let me know if I need to change the address.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/opentechschool/websitenext/5x0t1igpz ✅ Preview: https://websitenext-git-fork-morrme-patch-1.opentechschool.vercel.app

morrme commented 4 years ago

Here is the new icon: preview of change

morrme commented 4 years ago

@gsambrotta @normade @xMartin I'd like a review please.

xMartin commented 4 years ago

I'd say the Leipzig Insta account should be linked from the Leipzig chapter page.

Not sure if we have a global account registered.

morrme commented 4 years ago

Thank you @xMartin ! Was the idea of the original issue (#147 ) based on the assumption that an account was already created? Or was it just to provide the icon without linking it anywhere?

xMartin commented 4 years ago

I don't know. @normade ?

Currently I'm not aware of anyone being available to create content for a global insta account.

normade commented 4 years ago

Sorry @morrme and @xMartin, the issue is not specific enough. It was meant for the Leipzig chapter page, as we run an insta account for a while now and wanted to add it there. So we thought it would be nice to have the icon generally available to use it then for Leipzig.

morrme commented 4 years ago

@normade I see. So should I leave the icon in the import section, but remove it below where I linked to Leipzig's page?

morrme commented 4 years ago

@normade @xMartin I have left the instagram icon but removed the chapter page link. Does this complete the issue?

Twissi commented 4 years ago

@morrme sorry for the confusion. We would like to add the insta account to the Leipzig city page only, not in the global social media section.

Here a more detailed description:

  1. Add the insta account to the markdown file for Leipzig (en/leipzig.md, de/leipzig), similar to facebook
  2. Add the insta logo to the city page (as part of the socialIconsList) here: https://github.com/OpenTechSchool/websitenext/blob/master/pages/cities/%5Bslug%5D.js
  3. Make sure the insta logo shows up at https://www.opentechschool.org/cities/leipzig and links to the Leipzig insta account
  4. Make sure the insta logo does not show up at other city pages for example https://www.opentechschool.org/cities/berlin

Hope that helps! Let me know if you have any questions.

morrme commented 4 years ago

@Twissi Here is the new Leipzig page social section: leipzig ig

And here is Berlin:

berlinnoig

morrme commented 4 years ago

@twissi All done!

Twissi commented 4 years ago

@morrme looks great! Thank you so much!