Closed morrme closed 4 years ago
This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/opentechschool/websitenext/5x0t1igpz ✅ Preview: https://websitenext-git-fork-morrme-patch-1.opentechschool.vercel.app
Here is the new icon:
@gsambrotta @normade @xMartin I'd like a review please.
I'd say the Leipzig Insta account should be linked from the Leipzig chapter page.
Not sure if we have a global account registered.
Thank you @xMartin ! Was the idea of the original issue (#147 ) based on the assumption that an account was already created? Or was it just to provide the icon without linking it anywhere?
I don't know. @normade ?
Currently I'm not aware of anyone being available to create content for a global insta account.
Sorry @morrme and @xMartin, the issue is not specific enough. It was meant for the Leipzig chapter page, as we run an insta account for a while now and wanted to add it there. So we thought it would be nice to have the icon generally available to use it then for Leipzig.
@normade I see. So should I leave the icon in the import section, but remove it below where I linked to Leipzig's page?
@normade @xMartin I have left the instagram icon but removed the chapter page link. Does this complete the issue?
@morrme sorry for the confusion. We would like to add the insta account to the Leipzig city page only, not in the global social media section.
Here a more detailed description:
socialIconsList
) here: https://github.com/OpenTechSchool/websitenext/blob/master/pages/cities/%5Bslug%5D.jsHope that helps! Let me know if you have any questions.
@Twissi Here is the new Leipzig page social section:
And here is Berlin:
@twissi All done!
@morrme looks great! Thank you so much!
Fixes #147
Note: The instagram.com/opentechschool IG account was blank, so I used instagram.com/opentechschool_leipzig . Please let me know if I need to change the address.