search

OpenTechStrategies / streetcrm

StreetCRM is a free software contact management application
Other
5 stars 4 forks source link

Adding email to action sign-in sheet #314

Closed pjsier closed 7 years ago

pjsier commented 7 years ago

Addresses #302. After testing it out, it actually looks like email fits without expanding the form width, but the column headers are a little cramped. Given the title of the form is Attendees, is it alright to change the column names to just "Phone Number" and "Email"?

screen shot 2017-08-05 at 3 48 01 pm screen shot 2017-08-05 at 3 48 29 pm
cecilia-donnelly commented 7 years ago

@pjsier thanks for this! I think renaming the columns would be fine. Are you able to test on different browsers at all?

(More detailed review coming.)

pjsier commented 7 years ago

Just updated the names! I checked Chrome and Firefox, but if IE is a priority I can try and figure out setting up a VM (I'm on a Mac).

Also, this is partially related, but the gap on the left side of the phone input is because the information icon link is created and set to visibility: hidden. Not sure if it'd go in this PR, but I have a quick fix that uses display: none instead if that's worth cleaning up