search

OpenTechStrategies / torque

A flexible web-based open source system for collaboratively evaluating proposals.
1 stars 2 forks source link

Torque errors on upload #64

Open slifty opened 2 years ago

slifty commented 2 years ago

When I run ETL I'm seeing a few hundred errors in my torque logs similar to:

image

(one error per upload)

slifty commented 2 years ago

I don't know if this is related, but I also see a ton of messages like this:

image
frankduncan commented 2 years ago

The first message is weird. What are the parameters that are being passed in? Some debugging will help.

The second message is mediawiki attempting to render the page when you do something to it (like edit it via the etl pipeline that creates all the pages). I have waffled between keeping this error message around because it's the same one (and very useful) if something is messed up with a users permissions, and removing it because anytime we upload, mediawiki tries and renders the page (for search caching, among other things) with no user group.

slifty commented 2 years ago

@frankduncan got it -- will debug around the first.

Re the second, I think the right thing here would be to figure out a way to have that message NOT appear when the system is behaving as expected (e.g. during ETL) but still appear when the system is not behaving. Is there a way to modify ETL to make sure the proper information is passed, or some other indicator that would prevent the warning from triggering?

frankduncan commented 2 years ago

@slifty Yeah, we coudl disable the #tdcrender tag when the user is on a specific block list, and we could do things like add the bots we use for ETL to that. That might be good enough. The only thing we'd need is a global variable in torque that says "hey, don't render when this is set" and let script set it.

frankduncan commented 2 years ago

The first is actually caused a bug I introduced when uplaoding new attachments. Pushing a fix to main now (as it also broke production)